Thread (4 messages) 4 messages, 3 authors, 2022-03-02

Re: [PATCH bpf-next] bpf: test_run: Fix overflow in xdp frags bpf_test_finish

From: Stanislav Fomichev <hidden>
Date: 2022-03-01 16:38:39
Also in: bpf

On Tue, Mar 1, 2022 at 8:33 AM Daniel Borkmann [off-list ref] wrote:
On 3/1/22 12:23 AM, Stanislav Fomichev wrote:
quoted
Syzkaller reports another issue:
WARNING: CPU: 0 PID: 10775 at include/linux/thread_info.h:230
check_copy_size include/linux/thread_info.h:230 [inline]
WARNING: CPU: 0 PID: 10775 at include/linux/thread_info.h:230
copy_to_user include/linux/uaccess.h:199 [inline]
WARNING: CPU: 0 PID: 10775 at include/linux/thread_info.h:230
bpf_test_finish.isra.0+0x4b2/0x680 net/bpf/test_run.c:171

This can happen when the userspace buffer is smaller than head+frags.
Return ENOSPC in this case.

Fixes: 7855e0db150a ("bpf: test_run: add xdp_shared_info pointer in bpf_test_finish signature")
Cc: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Stanislav Fomichev <redacted>
Do we have a Reported-by tag for syzkaller so it can match against its report?
Oops, sorry, totally forgot:

Reported-by: syzbot+5f81df6205ecbbc56ab5@syzkaller.appspotmail.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help