RE: [EXT] Re: [PATCH v2 net-next 1/2] bnx2x: Utilize firmware 7.13.21.0

On Wed, 9 Mar 2022 14:18:23 -0800 Linus Torvalds wrote:

quoted

On Wed, Mar 9, 2022 at 11:46 AM Manish Chopra [off-list ref]

wrote:

quoted

quoted

This has not changed anything functionally from driver/device

perspective, FW is still being loaded only when device is opened.

quoted

quoted

bnx2x_init_firmware() [I guess, perhaps the name is misleading] just

request_firmware() to prepare the metadata to be used when device will be
opened.

quoted

So how do you explain the report by Paul Menzel that things used to
work and no longer work now?

You can't do request_firmware() early. When you actually then push the
firmware to the device is immaterial - but request_firmware() has to
be done after the system is up and running.

Alright, I don't see a revert in my inbox, so let me double check.

Linus, is my understanding correct that our PR today should revert
the patches in question [1]? Or just drop them from stable for now,
and give Manish and team a week or two to figure out a fix?

Manish, assuming it's the former - would you be able to provide
a revert within a couple of hours (and I mean  "couple" in the
British sense of roughly two)?

[1] patches in question:
 e13ad1443684 ("bnx2x: fix driver load from initrd")
 802d4d207e75 ("bnx2x: Invalidate fastpath HSI version for VFs")
 b7a49f73059f ("bnx2x: Utilize firmware 7.13.21.0")

Jackub, assuming former, we won't be able to provide anything in a couple of hours
(already past midnight in Manish's part of the world).

Linus, does "you can't request FW before system is up and running" translate to
"don't request FW at probe" or "don't request FW in initrd?"
Or perhaps something else?

Thanks,
Ariel