Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2022-03-01 23:09:35
Also in:
alsa-devel, amd-gfx, dmaengine, dri-devel, intel-gfx, intel-wired-lan, kvm, linux-arch, linux-aspeed, linux-block, linux-cifs, linux-crypto, linux-f2fs-devel, linux-fsdevel, linux-iio, linux-media, linux-mediatek, linux-pm, linux-rdma, linux-scsi, linux-staging, linux-tegra, linux-usb, linux-wireless, linuxppc-dev, lkml, nouveau
On Tue, Mar 1, 2022 at 2:58 PM David Laight [off-list ref] wrote:
Can it be resolved by making: #define list_entry_is_head(pos, head, member) ((pos) == NULL) and double-checking that it isn't used anywhere else (except in the list macros themselves).
Well, yes, except for the fact that then the name is entirely misleading...
And somebody possibly uses it together with list_first_entry() etc, so
it really is completely broken to mix that change with the list
traversal change.
Linus
Linus