On Mon, 2022-03-21 at 18:27 -0500, Rob Herring wrote:

EXTERNAL EMAIL: Do not click links or open attachments unless you know the
content is safe

On Fri, Mar 18, 2022 at 02:25:31PM +0530, Prasanna Vengateshan wrote:

quoted

mdio bus is applicable to any switch hence it is added as per the below
request,
https://lore.kernel.org/netdev/1300f84832ef1c43ecb9edb311fb817e3aab5420.camel@microchip.com/ (local)

Quoting that thread:

quoted

Yes indeed, since this is a common property of all DSA switches, it can
be defined or not depending on whether the switch does have an internal
MDIO bus controller or not.

Whether or not a switch has an MDIO controller or not is a property of
that switch and therefore 'mdio' needs to be documented in those switch
bindings.

quoted

Signed-off-by: Prasanna Vengateshan <redacted>
---
 Documentation/devicetree/bindings/net/dsa/dsa.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.yaml

b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
index b9d48e357e77..0f8426e219eb 100644

--- a/Documentation/devicetree/bindings/net/dsa/dsa.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/dsa.yaml

@@ -31,6 +31,10 @@ properties:

       switch 1. <1 0> is cluster 1, switch 0. A switch not part of any
cluster
       (single device hanging off a CPU port) must not specify this property
     $ref: /schemas/types.yaml#/definitions/uint32-array
+
+  mdio:
+    $ref: /schemas/net/mdio.yaml#
+    unevaluatedProperties: false

From a schema standpoint, this bans every switch from adding additional
properties under an mdio node. Not likely what you want.

Rob

Thanks for the feedback. Do you mean that the 'unevaluatedProperties: false' to
be removed, so that the additional properties can be added? or mdio is not
supposed to be defined in the dsa.yaml ?