Thread (73 messages) 73 messages, 7 authors, 2022-03-15

Re: [PATCH bpf-next v2 19/28] bpf/hid: add bpf_hid_raw_request helper function

flat view

From: Song Liu <song@kernel.org>
Date: 2022-03-11 00:50:28
Also in: bpf, linux-input, linux-kselftest, lkml

On Fri, Mar 4, 2022 at 9:35 AM Benjamin Tissoires
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
When we are in a user_event context, we can talk to the device to fetch
or set features/outputs/inputs reports.
Add a bpf helper to do so. This helper is thus only available to
user_events, because calling this function while in IRQ context (any
other BPF type) is forbidden.

Signed-off-by: Benjamin Tissoires <redacted>

---

changes in v2:
- split the series by bpf/libbpf/hid/selftests and samples
---
 include/linux/bpf-hid.h        |  2 ++
 include/uapi/linux/bpf.h       |  8 ++++++++
 kernel/bpf/hid.c               | 26 ++++++++++++++++++++++++++
 tools/include/uapi/linux/bpf.h |  8 ++++++++
 4 files changed, 44 insertions(+)
diff --git a/include/linux/bpf-hid.h b/include/linux/bpf-hid.h
index 4cf2e99109fe..bd548f6a4a26 100644
--- a/include/linux/bpf-hid.h
+++ b/include/linux/bpf-hid.h
@@ -100,6 +100,8 @@ struct bpf_hid_hooks {
                            u64 offset, u32 n, u8 *data, u64 data_size);
        int (*hid_set_data)(struct hid_device *hdev, u8 *buf, size_t buf_size,
                            u64 offset, u32 n, u8 *data, u64 data_size);
+       int (*hid_raw_request)(struct hid_device *hdev, u8 *buf, size_t size,
+                              u8 rtype, u8 reqtype);
 };

 #ifdef CONFIG_BPF
diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
index b3063384d380..417cf1c31579 100644
--- a/include/uapi/linux/bpf.h
+++ b/include/uapi/linux/bpf.h
@@ -5121,6 +5121,13 @@ union bpf_attr {
  *     Return
  *             The length of data copied into ctx->event.data. On error, a negative
  *             value is returned.
+ *
+ * int bpf_hid_raw_request(void *ctx, void *buf, u64 size, u8 rtype, u8 reqtype)
+ *     Description
+ *             communicate with the HID device
I think we need more description here, e.g. what are rtype and reqtype here?

quoted hunk ↗ jump to hunk
+ *     Return
+ *             0 on success.
+ *             negative value on error.
  */
 #define __BPF_FUNC_MAPPER(FN)          \
        FN(unspec),                     \
@@ -5317,6 +5324,7 @@ union bpf_attr {
        FN(copy_from_user_task),        \
        FN(hid_get_data),               \
        FN(hid_set_data),               \
+       FN(hid_raw_request),            \
        /* */
[...]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help