Thread (3 messages) 3 messages, 3 authors, 2022-03-12

RE: [PATCH] net: netvsc: remove break after return

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: 2022-03-10 18:07:20
Also in: linux-hyperv, lkml

quoted hunk ↗ jump to hunk
-----Original Message-----
From: Saurabh Sengar <ssengar@linux.microsoft.com>
Sent: Thursday, March 10, 2022 12:32 PM
To: Saurabh Singh Sengar <redacted>; Haiyang Zhang <haiyangz@microsoft.com>;
KY Srinivasan [off-list ref]; Stephen Hemminger [off-list ref];
wei.liu@kernel.org; Dexuan Cui [off-list ref]; davem@davemloft.net; kuba@kernel.org;
linux-hyperv@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH] net: netvsc: remove break after return

In function netvsc_process_raw_pkt for VM_PKT_DATA_USING_XFER_PAGES
case there is already a 'return' statement which results 'break'
as dead code

Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
---
 drivers/net/hyperv/netvsc.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index e675d10..9442f75 100644
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -1630,7 +1630,6 @@ static int netvsc_process_raw_pkt(struct hv_device *device,

 	case VM_PKT_DATA_USING_XFER_PAGES:
 		return netvsc_receive(ndev, net_device, nvchan, desc);
-		break;

 	case VM_PKT_DATA_INBAND:
Thanks.
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help