Thread (3 messages) 3 messages, 2 authors, 2022-03-10

Re: [PATCH] ax25: Fix memory leaks caused by ax25_cb_del()

From: Dan Carpenter <hidden>
Date: 2022-03-10 13:05:46
Also in: linux-hams, lkml

This is a very frustrating patch because you make a lot of unnecessary
white space changes and you didn't run checkpatch on your patch.

The whole approach feels like the wrong thing...

I have read your commit message, but I don't understand why we can't
just use normal refcounting.  It sounds like there is a layering
violation somewhere?

Even if we go with this approach ->kill_flag and ->bind_flag should be
booleans.  It makes no sense to have a unsigned long where only BIT(2)
can be set.

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help