Re: [PATCH net-next v4 2/4] net: tap: track dropped skb via kfree_skb_reason()
From: Jakub Kicinski <kuba@kernel.org>
Date: 2022-03-02 02:42:17
Also in:
bpf, lkml
From: Jakub Kicinski <kuba@kernel.org>
Date: 2022-03-02 02:42:17
Also in:
bpf, lkml
On Sat, 26 Feb 2022 00:49:27 -0800 Dongli Zhang wrote:
+ SKB_DROP_REASON_SKB_CSUM, /* sk_buff checksum error */
Can we spell it out a little more? It sounds like the checksum was incorrect. Will it be clear that computing the checksum failed, rather than checksum validation failed?
+ SKB_DROP_REASON_SKB_COPY_DATA, /* failed to copy data from or to + * sk_buff + */
Here should we specify that it's copying from user space?
+ SKB_DROP_REASON_SKB_GSO_SEG, /* gso segmentation error */ + SKB_DROP_REASON_DEV_HDR, /* there is something wrong with + * device driver specific header + */
How about: device driver specific header / metadata was invalid to broaden the scope also to devices which don't transfer the metadata in form of a header?
+ SKB_DROP_REASON_FULL_RING, /* ring buffer is full */