On Mon, Feb 28, 2022 at 2:21 PM Björn Töpel [off-list ref] wrote:

On Mon, 28 Feb 2022 at 10:46, Magnus Karlsson [off-list ref] wrote:

quoted

From: Magnus Karlsson <magnus.karlsson@intel.com>

Fix a race in the xsk socket teardown code that can lead to a null
pointer dereference splat. The current xsk unbind code in
xsk_unbind_dev() starts by setting xs->state to XSK_UNBOUND, sets
xs->dev to NULL and then waits for any NAPI processing to terminate
using synchronize_net(). After that, the release code starts to tear
down the socket state and free allocated memory.

[...]

quoted

v1 -> v2:
* Naming xsk_zc_xmit() -> xsk_wakeup() [Maciej]

Magnus,

You forgot to include my ACK! So, again:

Acked-by: Björn Töpel <bjorn@kernel.org>

Sorry for that Björn.

/Magnus

Cheers,
Björn