RE: [PATCH] ice: Don't use GFP_KERNEL in atomic context
From: Kaliszczuk, Leszek <hidden>
Date: 2022-02-28 15:08:00
Also in:
kernel-janitors, lkml
From: Kaliszczuk, Leszek <hidden>
Date: 2022-02-28 15:08:00
Also in:
kernel-janitors, lkml
-----Original Message-----
From: Christophe JAILLET <redacted>
Sent: Sunday, January 16, 2022 7:46 PM
To: Brandeburg, Jesse <redacted>; Nguyen, Anthony L
[off-list ref]; David S. Miller [off-list ref]; Jakub
Kicinski [off-list ref]; Saleem, Shiraz [off-list ref]; Ertman,
David M [off-list ref]
Cc: linux-kernel@vger.kernel.org; kernel-janitors@vger.kernel.org; Christophe
JAILLET [off-list ref]; intel-wired-lan@lists.osuosl.org;
netdev@vger.kernel.org
Subject: [PATCH] ice: Don't use GFP_KERNEL in atomic context
ice_misc_intr() is an irq handler. It should not sleep.
Use GFP_ATOMIC instead of GFP_KERNEL when allocating some memory.
Fixes: 348048e724a0 ("ice: Implement iidc operations")
Signed-off-by: Christophe JAILLET <redacted>
---
I've never played a lot with irq handler. My understanding is that they should never
sleep. So GFP_KERNEL must be avoided. So I guess that this patch is correct.
However, I don't know if some special cases allow such allocation.
Any feedback/pointer to a good doc/explanation is welcome :)
---
drivers/net/ethernet/intel/ice/ice_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)Tested-by: Leszek Kaliszczuk <redacted>