Thread (6 messages) 6 messages, 2 authors, 2022-03-03

Re: [PATCH V2] selftests: Fix build when $(O) points to a relative path

From: Shuah Khan <skhan@linuxfoundation.org>
Date: 2022-02-25 18:01:53
Also in: bpf, kernelci, linux-kselftest, lkml

On 2/25/22 10:22 AM, Muhammad Usama Anjum wrote:
Any thoughts about it?
No to post please.
On 2/17/22 3:38 AM, Muhammad Usama Anjum wrote:
quoted
Build of bpf and tc-testing selftests fails when the relative path of
the build directory is specified.

make -C tools/testing/selftests O=build0
make[1]: Entering directory '/linux_mainline/tools/testing/selftests/bpf'
../../../scripts/Makefile.include:4: *** O=build0 does not exist.  Stop.
make[1]: Entering directory '/linux_mainline/tools/testing/selftests/tc-testing'
../../../scripts/Makefile.include:4: *** O=build0 does not exist.  Stop.

Makefiles of bpf and tc-testing include scripts/Makefile.include file.
This file has sanity checking inside it which checks the output path.
The output path is not relative to the bpf or tc-testing. The sanity
check fails. Expand the output path to get rid of this error. The fix is
the same as mentioned in commit 150a27328b68 ("bpf, preload: Fix build
when $(O) points to a relative path").

Signed-off-by: Muhammad Usama Anjum <redacted>
---
Changes in V2:
Add more explaination to the commit message.
Support make install as well.
Looks god to me. I can pull this in for Linux 5.18-rc1

thanks,
-- Shuah
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help