Thread (74 messages) 74 messages, 7 authors, 2022-02-25
STALE1583d REVIEWED: 1 (0M)

[PATCH 10/22] uio: pruss: Don't use GFP_DMA when calling dma_alloc_coherent()

From: Baoquan He <hidden>
Date: 2022-02-19 00:54:51
Also in: linux-crypto, linux-i2c, linux-mm, linux-s390, lkml
Subsystem: the rest, userspace i/o (uio) · Maintainers: Linus Torvalds, Greg Kroah-Hartman

dma_alloc_coherent() allocates dma buffer with device's addressing
limitation in mind. It's redundent to specify GFP_DMA when calling
dma_alloc_coherent().

[ 42.hyeyoo@gmail.com: Update changelog ]

Signed-off-by: Baoquan He <redacted>
Acked-by: Hyeonggon Yoo <redacted>
---
 drivers/uio/uio_pruss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/uio/uio_pruss.c b/drivers/uio/uio_pruss.c
index e9096f53b4cc..1de39875d436 100644
--- a/drivers/uio/uio_pruss.c
+++ b/drivers/uio/uio_pruss.c
@@ -168,7 +168,7 @@ static int pruss_probe(struct platform_device *pdev)
 	}
 
 	gdev->ddr_vaddr = dma_alloc_coherent(dev, extram_pool_sz,
-				&(gdev->ddr_paddr), GFP_KERNEL | GFP_DMA);
+				&(gdev->ddr_paddr), GFP_KERNEL);
 	if (!gdev->ddr_vaddr) {
 		dev_err(dev, "Could not allocate external memory\n");
 		ret = -ENOMEM;
-- 
2.17.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help