Re: [PATCH v3 5/8] ARM: dts: exynos: fix ethernet node name for different odroid boards
From: Oleksij Rempel <o.rempel@pengutronix.de>
Date: 2022-02-15 08:17:11
Also in:
linux-arm-kernel, linux-devicetree, linux-omap, linux-samsung-soc, linux-tegra, linux-usb, lkml
On Tue, Feb 15, 2022 at 09:12:40AM +0100, Marc Kleine-Budde wrote:
On 15.02.2022 09:09:34, Oleksij Rempel wrote:quoted
The node name of Ethernet controller should be "ethernet" instead of "usbether" Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- arch/arm/boot/dts/exynos4412-odroidu3.dts | 4 ++-- arch/arm/boot/dts/exynos4412-odroidx.dts | 8 ++++---- arch/arm/boot/dts/exynos5410-odroidxu.dts | 4 ++-- arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts | 6 +++--- arch/arm/boot/dts/exynos5422-odroidxu3.dts | 6 +++--- 5 files changed, 14 insertions(+), 14 deletions(-)diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts index efaf7533e84f..36c369c42b77 100644 --- a/arch/arm/boot/dts/exynos4412-odroidu3.dts +++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts@@ -119,8 +119,8 @@ &ehci { phys = <&exynos_usbphy 2>, <&exynos_usbphy 3>; phy-names = "hsic0", "hsic1"; - ethernet: usbether@2 { - compatible = "usb0424,9730"; + ethernet: ethernet@2 { + compatible = "usb424,9730";The change of the compatible is not mentioned in the patch description. Is this intentional?
No, I forgot to mentione it. According to the USB schema 0 should be removed. So, this compatible was incorrect as well. With leading zero present yaml schema was not able to detect and validate this node. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |