Re: [PATCH] net: mvpp2: Check for null pcs in mvpp2_acpi_start()

On Fri, Feb 11, 2022 at 06:18:22PM -0600, Jeremy Linton wrote:

Hi,

On 2/11/22 17:49, Russell King (Oracle) wrote:

quoted

On Fri, Feb 11, 2022 at 05:42:35PM -0600, Jeremy Linton wrote:

quoted

Booting a MACCHIATObin with 5.17 the system OOPs with
a null pointer deref when the network is started. This
is caused by the pcs->ops structure being null on this
particular platform/firmware.

pcs->ops should never be NULL. I'm surprised this fix results in any
kind of working networking.

Instead, the initialilsation of port->pcs_*.ops needs to be moved out
of the if (!mvpp2_use_acpi_compat_mode(..)) block. Please try this:

That appears to fix it as well, shall I re-post this with your fix, or will
you?

I see you re-posted it anyway - that's fine. Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!