Re: [PATCH net-next 0/4] net/mlx5: Introduce devlink param to disable SF aux dev probe

On 2/10/2022 9:02 AM, Jiri Pirko wrote:

Thu, Feb 10, 2022 at 02:25:25AM CET, kuba@kernel.org wrote:

quoted

On Wed, 9 Feb 2022 09:39:54 +0200 Moshe Shemesh wrote:

quoted

Well we don't have the SFs at that stage, how can we tell which SF will
use vnet and which SF will use eth ?

On Wed, 9 Feb 2022 10:57:21 +0100 Jiri Pirko wrote:

quoted

It's a different user. One works with the eswitch and creates the port
function. The other one takes the created instance and works with it.
Note that it may be on a different host.

It is a little confusing, so I may well be misunderstanding but the
cover letter says:

$ devlink dev param set pci/0000:08:00.0 name enable_sfs_aux_devs \
              value false cmode runtime

$ devlink port add pci/0000:08:00.0 flavour pcisf pfnum 0 sfnum 11

So both of these run on the same side, no?

Yes.

quoted

What I meant is make the former part of the latter:

$ devlink port add pci/0000:08:00.0 flavour pcisf pfnum 0 sfnum 11 noprobe

I see. So it would not be "global policy" but per-instance option during
creation. That makes sense. I wonder if the HW is capable of such flow,
Moshe, Saeed?

LGTM. Thanks.

quoted

Maybe worth clarifying - pci/0000:08:00.0 is the eswitch side and
auxiliary/mlx5_core.sf.1 is the... "customer" side, correct?

Yep.