Re: [PATCH] staging: qlge: Fix checkpatch errors in the module
From: Randy Dunlap <rdunlap@infradead.org>
Date: 2022-02-07 16:16:51
Also in:
linux-staging, lkml
Hi-- On 2/6/22 23:15, Ayan Choudhary wrote:
The qlge module had many checkpatch errors, this patch fixes most of them. The errors which presently remain are either false positives or introduce unncessary comments in the code.
I guess that most of these are warnings and not errors, but since none of them are quoted here, I cannot tell that for sure.
quoted hunk ↗ jump to hunk
Signed-off-by: Ayan Choudhary <redacted> --- drivers/staging/qlge/Kconfig | 8 +++++--- drivers/staging/qlge/TODO | 1 - drivers/staging/qlge/qlge.h | 24 ++++++++++++------------ drivers/staging/qlge/qlge_main.c | 12 +++++++++--- drivers/staging/qlge/qlge_mpi.c | 11 +++++------ 5 files changed, 31 insertions(+), 25 deletions(-)diff --git a/drivers/staging/qlge/Kconfig b/drivers/staging/qlge/Kconfig index 6d831ed67965..21fd3f6e33d6 100644 --- a/drivers/staging/qlge/Kconfig +++ b/drivers/staging/qlge/Kconfig@@ -5,7 +5,9 @@ config QLGE depends on ETHERNET && PCI select NET_DEVLINK help - This driver supports QLogic ISP8XXX 10Gb Ethernet cards. + This driver supports QLogic ISP8XXX 10Gb Ethernet cards. - To compile this driver as a module, choose M here. The module will be - called qlge. + Say Y here to enable support for QLogic ISP8XXX 10Gb Ethernet cards. + + To compile this driver as a module, choose M here. The module will be + called qlge.
Anyway, please follow coding-style for Kconfig files: (from Documentation/process/coding-style.rst, section 10): For all of the Kconfig* configuration files throughout the source tree, the indentation is somewhat different. Lines under a ``config`` definition are indented with one tab, while help text is indented an additional two spaces. thanks. -- ~Randy