Hi Alexandru,

On Sat, Dec 11, 2021 at 10:07:49PM +0100, Andrew Lunn wrote:

quoted

+		ret = phy_read_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_PMA_EXTABLE);
+		if (ret < 0)
+			return ret;
+
+		if (ret & MDIO_PMA_EXTABLE_BT1)

This pattern of reading the MDIO_PMA_EXTABLE register and then looking
for bit MDIO_PMA_EXTABLE_BT1 happens a lot. It is not something which
is expected to change is it? So i wounder if it should be read once
and stored away?

What is the state of this patches? Will you be able to make requested
changes and send new version?

Regards,
Oleskij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |