Re: [PATCH][next] net: sundance: Replace one-element array with non-array object

From
Jakub Kicinski <kuba@kernel.org>
Date
2022-02-05 03:40:18
Also in
linux-hardening, lkml
Reply to
Gustavo A. R. Silva, 2022-02-04
On Fri, 4 Feb 2022 17:29:06 -0600 Gustavo A. R. Silva wrote:
It seems this one-element array is not actually being used as an
array of variable size, so we can just replace it with just a
non-array object of type struct desc_frag and refactor a bit the
rest of the code.

This helps with the ongoing efforts to globally enable -Warray-bounds
and get us closer to being able to tighten the FORTIFY_SOURCE routines
on memcpy().

This issue was found with the help of Coccinelle and audited and fixed,
manually.

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays

Link: https://github.com/KSPP/linux/issues/79
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Thread (2 messages) 2 messages, 2 authors, last reply 2022-02-05
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help