Thread (3 messages) 3 messages, 3 authors, 2022-02-03

Re: [PATCH] ax25: fix reference count leaks of ax25_dev

From: Dan Carpenter <hidden>
Date: 2022-02-03 17:15:07
Also in: linux-hams, lkml

On Thu, Feb 03, 2022 at 11:08:11PM +0800, Duoming Zhou wrote:
The previous commit d01ffb9eee4a ("ax25: add refcount in ax25_dev
to avoid UAF bugs") introduces refcount into ax25_dev, but there
are reference leak paths in ax25_ctl_ioctl(), ax25_fwd_ioctl(),
ax25_rt_add(), ax25_rt_del() and ax25_rt_opt().

This patch uses ax25_dev_put() and adjusts the position of
ax25_addr_ax25dev() to fix reference cout leaks of ax25_dev.

Fixes: d01ffb9eee4a ("ax25: add refcount in ax25_dev to avoid UAF bugs")
Signed-off-by: Duoming Zhou <redacted>
---
Much better, thanks!

Reviewed-by: Dan Carpenter <redacted>

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help