Re: [net-next PATCH v8 07/16] net: dsa: tag_qca: add define for handling MIB packet
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2022-02-02 02:56:30
Also in:
lkml
On 2/1/2022 4:03 PM, Ansuel Smith wrote:
quoted hunk ↗ jump to hunk
Add struct to correctly parse a mib Ethernet packet. Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> --- include/linux/dsa/tag_qca.h | 10 ++++++++++ net/dsa/tag_qca.c | 4 ++++ 2 files changed, 14 insertions(+)diff --git a/include/linux/dsa/tag_qca.h b/include/linux/dsa/tag_qca.h index f366422ab7a0..1fff57f2937b 100644 --- a/include/linux/dsa/tag_qca.h +++ b/include/linux/dsa/tag_qca.h@@ -62,4 +62,14 @@ struct qca_mgmt_ethhdr { __be16 hdr; /* qca hdr */ } __packed; +enum mdio_cmd { + MDIO_WRITE = 0x0, + MDIO_READ +}; + +struct mib_ethhdr { + u32 data[3]; /* first 3 mib counter */ + __be16 hdr; /* qca hdr */ +} __packed;
For consistency with patch 7, you might want to name this structure qca_mib_ethhdr? Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian