Thread (17 messages) flat view 17 messages, 3 authors, 2022-02-25

Re: [PATCH RFC net-next 5/6] net: dsa: sja1105: convert to phylink_generic_validate()

From: Vladimir Oltean <olteanv@gmail.com>
Date: 2022-02-25 10:44:50

On Thu, Feb 24, 2022 at 04:15:36PM +0000, Russell King (Oracle) wrote:
Populate the MAC capabilities for the SJA1105 DSA switch using the same
decision making which sja1105_phylink_validate() uses. Remove the now
obsolete sja1105_phylink_validate() implementation to allow DSA to use
phylink_generic_validate() for this switch driver.

As noted by Vladimir, this fixes an inconsequential bug which allowed
gigabit and lower interface modes to be indicated when operating in
2500base-X mode.

Signed-off-by: Russell King (Oracle) <redacted>
---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help