Re: [PATCH net-next 1/1] ice: add TTY for GNSS module for E810T device

On Wed, 2022-02-23 at 12:37 -0800, Richard Cochran wrote:

On Wed, Feb 23, 2022 at 07:20:43PM +0000, Nguyen, Anthony L wrote:

quoted

I haven't heard anything back. Are we ok with this convention? Just
to
add this usage is fairly standard for our driver structures
especially
in this ice_adminq.h file.

I would put the #defines just above the struct, but maybe that is
more
of a personal preference of mine.  I don't think there is a tree wide
CodingStyle rule about this.

Thanks Richard. Since there's already this current style, I'd like to
keep everything consistent.

Dave, Jakub,

If you're okay with this, it looks like this patch still applies
cleanly. Would you like me to resend it or did you want to use this
one?

Thanks,
Tony