Re: [net-next v6 1/2] page_pool: Add page_pool stats
From: Joe Damato <hidden>
Date: 2022-02-23 18:17:56
On Wed, Feb 23, 2022 at 10:10 AM Jesper Dangaard Brouer [off-list ref] wrote:
On 23/02/2022 18.45, Joe Damato wrote:quoted
On Wed, Feb 23, 2022 at 9:40 AM Jakub Kicinski [off-list ref] wrote:quoted
On Wed, 23 Feb 2022 09:05:06 -0800 Joe Damato wrote:quoted
Are the cache-line placement and per-cpu designations the only remaining issues with this change?page_pool_get_stats() has no callers as is, I'm not sure how we can merge it in current form. Maybe I'm missing bigger picture or some former discussion.I wrote the mlx5 code to call this function and export the data via ethtool. I had assumed the mlx5 changes should be in a separate patchset. I can include that code as part of this change, if needed.I agree with Jakub we need to see how this is used by drivers.
OK. I'll include the mlx5 code which uses this API in the v7.