Thread (28 messages) flat view 28 messages, 2 authors, 2022-02-26

Re: [PATCH net-next v2 07/12] rtnetlink: add new rtm tunnel api for tunnel id filtering

From: Jakub Kicinski <kuba@kernel.org>
Date: 2022-02-23 01:26:37

On Tue, 22 Feb 2022 02:52:25 +0000 Roopa Prabhu wrote:
+	RTM_NEWTUNNEL = 120,
+#define RTM_NEWTUNNEL	RTM_NEWTUNNEL
+	RTM_DELTUNNEL,
+#define RTM_DELTUNNEL	RTM_DELTUNNEL
+	RTM_GETTUNNEL,
+#define RTM_GETTUNNEL	RTM_GETTUNNEL
Why create new RTM_ commands instead of using changelink?

I thought we had to add special commands for bridge because
if the target of the command is not a bridge device but possibly 
a bridge port, which could be anything. That's not the case here.

Is it only about the convenience of add/del vs changelink where
we'd potentially have to pass and parse the entire vni list each time?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help