On 2/17/22 8:12 PM, Jakub Kicinski wrote:

On Thu, 17 Feb 2022 14:02:49 -0800 Shannon Nelson wrote:

quoted

In some graceful updates that get initially triggered by the
RESET event, especially with older firmware, the fw_generation
bits don't change but the fw_status is seen to go to 0 then back
to 1.  However, the driver didn't perform the restart, remained
waiting for fw_generation to change, and got left in limbo.

This is because the clearing of idev->fw_status_ready to 0
didn't happen correctly as it was buried in the transition
trigger: since the transition down was triggered not here
but in the RESET event handler, the clear to 0 didn't happen,
so the transition back to 1 wasn't detected.

Fix this particular case by bringing the setting of
idev->fw_status_ready back out to where it was before.

Fixes: 398d1e37f960 ("ionic: add FW_STOPPING state")
Signed-off-by: Shannon Nelson <redacted>

This looks like a fix, and should go separately to net.
Is there a reason behind posting together? The other patches
don't even depend on this one.

I posted it to net-next because the patch it is fixing is still in 
net-next and not in net or stable yet.

sln