Re: [PATCH net-next v2] net: gro: Fix a 'directive in macro's argument list' sparse warning
From: Paolo Abeni <pabeni@redhat.com>
Date: 2022-02-17 09:36:46
On Thu, 2022-02-17 at 10:07 +0200, Gal Pressman wrote:
quoted hunk ↗ jump to hunk
Following the cited commit, sparse started complaining about: ../include/net/gro.h:58:1: warning: directive in macro's argument list ../include/net/gro.h:59:1: warning: directive in macro's argument list Fix that by moving the defines out of the struct_group() macro. Fixes: de5a1f3ce4c8 ("net: gro: minor optimization for dev_gro_receive()") Reviewed-by: Maxim Mikityanskiy <redacted> Signed-off-by: Gal Pressman <redacted> Acked-by: Alexander Lobakin <redacted> --- Changelog - v1->v2: https://lore.kernel.org/netdev/20220216103100.9489-1-gal@nvidia.com/ (local) * Add a comment and fix alignment --- include/net/gro.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)diff --git a/include/net/gro.h b/include/net/gro.h index a765fedda5c4..867656b0739c 100644 --- a/include/net/gro.h +++ b/include/net/gro.h@@ -35,6 +35,9 @@ struct napi_gro_cb { /* jiffies when first packet was created/queued */ unsigned long age; +/* Used in napi_gro_cb::free */ +#define NAPI_GRO_FREE 1 +#define NAPI_GRO_FREE_STOLEN_HEAD 2 /* portion of the cb set to zero at every gro iteration */ struct_group(zeroed,@@ -55,8 +58,6 @@ struct napi_gro_cb { /* Free the skb? */ u8 free:2; -#define NAPI_GRO_FREE 1 -#define NAPI_GRO_FREE_STOLEN_HEAD 2 /* Used in foo-over-udp, set in udp[46]_gro_receive */ u8 is_ipv6:1;
LGTM, thanks! Acked-by: Paolo Abeni <pabeni@redhat.com>