Re: [RFC PATCH net-next 0/5] Replay and offload host VLAN entries in DSA
flat view
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: 2022-02-14 10:45:00
On Mon, Feb 14, 2022 at 11:59:02AM +0200, Ido Schimmel wrote:
Sounds good to me as well. I assume it means patches #1 and #2 will be changed to make use of this flag and patch #3 will be dropped?
Not quite. Patches 1 and 2 will be kept as-is, since fundamentally, their goal is to eliminate a useless SWITCHDEV_PORT_OBJ_ADD event when really nothing has changed (flags == old_flags, no brentry was created). Patch 3 will be replaced with another patch that extends br_switchdev_port_vlan_add() and struct switchdev_obj_port_vlan with a "bool changed" meaning that "this notification signifies a change of flags for an existing VLAN", and the callers of br_switchdev_port_vlan_add() will populate it with false, or *changed, or *flags_changed, as appropriate.