Thread (16 messages) flat view 16 messages, 4 authors, 2022-02-17

Re: [RFC PATCH net-next 1/2] net: dsa: allow setting port-based QoS priority using tc matchall skbedit

From: Andrew Lunn <andrew@lunn.ch>
Date: 2022-02-11 16:08:56

quoted
Now I don't understand DSA at all, but given a chip with fancy defaults,
for the DCB interface in particular, it would make sense to me to have
two ops. As long as there are default-prio entries, a "set default
priority" op would get invoked with the highest configured default
priority. When the last entry disappears, an "unset" op would be called.
I don't understand this comment, sorry. I don't know what's a "chip with
fancy defaults".
I think this is the point i just razed in my other reply. The hardware
starts with a preconfigured QoS profile. My guess would be, a Top Of
Rack defaults to all QoS features turned off, you need to turn them
off as appropriate for the use case. Typically, a SOHO switch is not
configured, it is just put in the corner and turned on. So having some
sensible defaults for a home/office makes sense. When it is used in
some other embedded use case, it probably is going to get configured
for that use cases.

So 'fancy defaults' == preconfigured QoS profile in the hardware.

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help