Thread (8 messages) 8 messages, 6 authors, 2022-02-11

Re: [PATCH net-next] net: dsa: realtek: realtek-mdio: reset before setup

From: Linus Walleij <hidden>
Date: 2022-02-11 10:30:36

On Fri, Feb 11, 2022 at 10:54 AM Alvin Šipraga [off-list ref] wrote:
Luiz Angelo Daros de Luca [off-list ref] writes:
quoted
+     if (priv->reset) {
gpiod_set_value seems tolerant of a NULL gpio_desc pointer, but perhaps
you would like to add the same if statement to realtek-smi so that it
doesn't pretend to reset the chip when the reset GPIO is absent?
That is fine by me and you can keep my review tag if you also
add this.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help