Hi Marc,

On Wed, Jan 12, 2022 at 7:43 PM Marc Kleine-Budde [off-list ref] wrote:

On 11.01.2022 17:22:28, Ulrich Hecht wrote:

quoted

Adds support for the CANFD IP variant in the V3U SoC.

Differences to controllers in other SoCs are limited to an increase in
the number of channels from two to eight, an absence of dedicated
registers for "classic" CAN mode, and a number of differences in magic
numbers (register offsets and layouts).

Inspired by BSP patch by Kazuya Mizuguchi.

Signed-off-by: Ulrich Hecht <redacted>

quoted

--- a/drivers/net/can/rcar/rcar_canfd.c
+++ b/drivers/net/can/rcar/rcar_canfd.c

quoted

-     of_child = of_get_child_by_name(pdev->dev.of_node, "channel1");
-     if (of_child && of_device_is_available(of_child))
-             channels_mask |= BIT(1);        /* Channel 1 */
+     strcpy(name, "channelX");

please use strlcpy()

Why? To cause a silent failure instead of a possible crash, in the unlikely
case the buffer is shrinked or the string is enlarged?

What about preinitializing it at declaration time instead:

    char name[9] = "channelX";

?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds