Re: [PATCH net 1/2] net: bridge: mcast: add and enforce query interval minimum
From: Eric Dumazet <hidden>
Date: 2022-01-05 18:14:43
Also in:
bridge, stable
From: Eric Dumazet <hidden>
Date: 2022-01-05 18:14:43
Also in:
bridge, stable
On 12/27/21 09:21, Nikolay Aleksandrov wrote:
As reported[1] if query interval is set too low and we have multiple bridges or even a single bridge with multiple querier vlans configured we can crash the machine. Add a 1 second minimum which must be enforced by overwriting the value if set lower (i.e. without returning an error) to avoid breaking user-space. If that happens a log message is emitted to let the administrator know that the interval has been set to the minimum. The issue has been present since these intervals could be user-controlled. [1] https://lore.kernel.org/netdev/e8b9ce41-57b9-b6e2-a46a-ff9c791cf0ba@gmail.com/ (local) Fixes: d902eee43f19 ("bridge: Add multicast count/interval sysfs entries") Reported-by: Eric Dumazet <redacted> Signed-off-by: Nikolay Aleksandrov <redacted> ---
Reviewed-by: Eric Dumazet <edumazet@google.com> Thanks !