Re: [PATCH v4 net-next 0/2] use bulk reads for ocelot statistics
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: 2022-01-31 20:06:10
Also in:
lkml
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: 2022-01-31 20:06:10
Also in:
lkml
On Mon, Jan 31, 2022 at 11:56:21AM -0800, Jakub Kicinski wrote:
On Fri, 28 Jan 2022 12:05:47 -0800 Colin Foster wrote:quoted
Ocelot loops over memory regions to gather stats on different ports. These regions are mostly continuous, and are ordered. This patch set uses that information to break the stats reads into regions that can get read in bulk. The motiviation is for general cleanup, but also for SPI. Performing two back-to-back reads on a SPI bus require toggling the CS line, holding, re-toggling the CS line, sending 3 address bytes, sending N padding bytes, then actually performing the read. Bulk reads could reduce almost all of that overhead, but require that the reads are performed via regmap_bulk_read.This got into Changes Requested state in patchwork, I'm not sure why. I revived it and will apply it by the end of the day PST if nobody raises comments.
Maybe this is the reason? https://patchwork.kernel.org/project/netdevbpf/patch/20220125071531.1181948-3-colin.foster@in-advantage.com/#24717872