Thread (8 messages) 8 messages, 2 authors, 2022-01-29

Re: [RESEND PATCH net-next 2/2] net: hns3: add ethtool priv-flag for TX push

From: huangguangbin (A) <hidden>
Date: 2022-01-29 01:14:21
Also in: lkml


On 2022/1/26 11:55, Jakub Kicinski wrote:
On Tue, 25 Jan 2022 15:21:49 +0800 Guangbin Huang wrote:
quoted
From: Yufeng Mo <redacted>

Add a control private flag in ethtool for enable/disable
TX push feature.
I think it's a pretty standard feature for NICs which also support RDMA.
Mellanox/nVidia has it (or at least it the previous gen HW did),
Broadcom's bnxt driver does it as well.

Can we make this a standard knob via ethtool? Not entirely sure under
which switch, maybe it's okay to add it under -g? Perhaps we need a new
command similar to -k but for features contained entirely to the driver?
.
Hi Jakub,
We consider adding a new command for this feature. We will send RFC after we finish it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help