Re: [PATCH] vhost: Make use of the helper macro kthread_run()
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2022-01-27 12:42:09
Also in:
kvm, lkml, virtualization
On Thu, Jan 27, 2022 at 10:08:07AM +0800, Yin Xiujiang wrote:
quoted hunk ↗ jump to hunk
Repalce kthread_create/wake_up_process() with kthread_run() to simplify the code. Signed-off-by: Yin Xiujiang <redacted> --- drivers/vhost/vhost.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 59edb5a1ffe2..19e9eda9fc71 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c@@ -595,7 +595,7 @@ long vhost_dev_set_owner(struct vhost_dev *dev) dev->kcov_handle = kcov_common_handle(); if (dev->use_worker) { - worker = kthread_create(vhost_worker, dev, + worker = kthread_run(vhost_worker, dev, "vhost-%d", current->pid); if (IS_ERR(worker)) { err = PTR_ERR(worker);@@ -603,7 +603,6 @@ long vhost_dev_set_owner(struct vhost_dev *dev) } dev->worker = worker; - wake_up_process(worker); /* avoid contributing to loadavg */ err = vhost_attach_cgroups(dev); if (err)
I think if you do this, you need to set dev->worker earlier.
-- 2.30.0