Re: [PATCH v12, 2/2] net: Add dm9051 driver

On Fri, Jan 21, 2022 at 12:37 PM Andy Shevchenko
[off-list ref] wrote:

On Fri, Jan 21, 2022 at 6:15 AM Joseph CHAMG [off-list ref] wrote:

...

quoted

correctly use regmap bulk read/write/update_bits APIs
use mdiobus to work to phylib and to this driver
fine tune to arrange the source code to better usage

This is not tagged properly. Also, I specifically removed everything
else to point out, please, read finally the article [1] and write a
proper commit message. And move changelog under the cutter '--- '
line. Without doing these two things nobody can do anything with your
contribution.

Next comment, remove all those `unlickely()` calls. Otherwise you have
to justify their appearance.

[1]: https://cbea.ms/git-commit/

-- 
With Best Regards,
Andy Shevchenko