Re: [PATCH] net/bluetooth: remove unneeded err variable
From: Marcel Holtmann <marcel@holtmann.org>
Date: 2022-01-19 19:34:05
Also in:
linux-bluetooth, lkml
Hi Minghao,
Return value from mgmt_cmd_complete() directly instead of taking this in another redundant variable.
the Bluetooth subsystem uses Bluetooth: as subject prefix.
quoted hunk ↗ jump to hunk
Reported-by: Zeal Robot <redacted> Signed-off-by: Minghao Chi <redacted> Signed-off-by: CGEL ZTE <redacted> --- net/bluetooth/mgmt.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c index 37087cf7dc5a..d0804648da32 100644 --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c@@ -8601,7 +8601,6 @@ static int get_adv_size_info(struct sock *sk, struct hci_dev *hdev,struct mgmt_cp_get_adv_size_info *cp = data; struct mgmt_rp_get_adv_size_info rp; u32 flags, supported_flags; - int err; bt_dev_dbg(hdev, "sock %p", sk);@@ -8628,10 +8627,8 @@ static int get_adv_size_info(struct sock *sk, struct hci_dev *hdev,rp.max_adv_data_len = tlv_data_max_len(hdev, flags, true); rp.max_scan_rsp_len = tlv_data_max_len(hdev, flags, false); - err = mgmt_cmd_complete(sk, hdev->id, MGMT_OP_GET_ADV_SIZE_INFO, + return mgmt_cmd_complete(sk, hdev->id, MGMT_OP_GET_ADV_SIZE_INFO, MGMT_STATUS_SUCCESS, &rp, sizeof(rp)); - - return err; }
You also have a coding style error here in your indentation. Regards Marcel