Re: [PATCH v3 3/9] brcmfmac: firmware: Do not crash on a NULL board_type

[PATCH v3 0/9] misc brcmfmac fixes (M1/T2 series spin-off) · Hector Martin <hidden> · 2022-01-17
[PATCH v3 1/9] brcmfmac: pcie: Release firmwares in the brcmf_pcie_setup error path · Hector Martin <hidden> · 2022-01-17
Re: [PATCH v3 1/9] brcmfmac: pcie: Release firmwares in the brcmf_pcie_setup error path · Arend van Spriel <arend.vanspriel@broadcom.com> · 2022-01-19
Re: [PATCH v3 1/9] brcmfmac: pcie: Release firmwares in the brcmf_pcie_setup error path · Andy Shevchenko <hidden> · 2022-01-19
Re: [PATCH v3 1/9] brcmfmac: pcie: Release firmwares in the brcmf_pcie_setup error path · Dmitry Osipenko <digetx@gmail.com> · 2022-01-19
Re: [PATCH v3 1/9] brcmfmac: pcie: Release firmwares in the brcmf_pcie_setup error path · Andy Shevchenko <hidden> · 2022-01-19
Re: [PATCH v3 1/9] brcmfmac: pcie: Release firmwares in the brcmf_pcie_setup error path · Dmitry Osipenko <digetx@gmail.com> · 2022-01-20
Re: [PATCH v3 1/9] brcmfmac: pcie: Release firmwares in the brcmf_pcie_setup error path · Arend van Spriel <arend.vanspriel@broadcom.com> · 2022-01-20
[PATCH v3 2/9] brcmfmac: firmware: Allocate space for default boardrev in nvram · Hector Martin <hidden> · 2022-01-17
Re: [PATCH v3 2/9] brcmfmac: firmware: Allocate space for default boardrev in nvram · Arend van Spriel <arend.vanspriel@broadcom.com> · 2022-01-19
Re: [PATCH v3 2/9] brcmfmac: firmware: Allocate space for default boardrev in nvram · Andy Shevchenko <hidden> · 2022-01-19
Re: [PATCH v3 2/9] brcmfmac: firmware: Allocate space for default boardrev in nvram · Hector Martin <hidden> · 2022-01-20
[PATCH v3 3/9] brcmfmac: firmware: Do not crash on a NULL board_type · Hector Martin <hidden> · 2022-01-17
Re: [PATCH v3 3/9] brcmfmac: firmware: Do not crash on a NULL board_type · Arend van Spriel <arend.vanspriel@broadcom.com> · 2022-01-19
Re: [PATCH v3 3/9] brcmfmac: firmware: Do not crash on a NULL board_type · Andy Shevchenko <hidden> · 2022-01-19
Re: [PATCH v3 3/9] brcmfmac: firmware: Do not crash on a NULL board_type · Hector Martin <hidden> · 2022-01-20
Re: [PATCH v3 3/9] brcmfmac: firmware: Do not crash on a NULL board_type · Dmitry Osipenko <digetx@gmail.com> · 2022-01-19
Re: [PATCH v3 3/9] brcmfmac: firmware: Do not crash on a NULL board_type · Arend van Spriel <arend.vanspriel@broadcom.com> · 2022-01-20
Re: [PATCH v3 3/9] brcmfmac: firmware: Do not crash on a NULL board_type · Dmitry Osipenko <digetx@gmail.com> · 2022-01-20
Re: [PATCH v3 3/9] brcmfmac: firmware: Do not crash on a NULL board_type · Dmitry Osipenko <digetx@gmail.com> · 2022-01-20
Re: [PATCH v3 3/9] brcmfmac: firmware: Do not crash on a NULL board_type · Arend van Spriel <arend.vanspriel@broadcom.com> · 2022-01-20
[PATCH v3 5/9] brcmfmac: pcie: Replace brcmf_pcie_copy_mem_todev with memcpy_toio · Hector Martin <hidden> · 2022-01-17
Re: [PATCH v3 5/9] brcmfmac: pcie: Replace brcmf_pcie_copy_mem_todev with memcpy_toio · Arend van Spriel <arend.vanspriel@broadcom.com> · 2022-01-19
Re: [PATCH v3 5/9] brcmfmac: pcie: Replace brcmf_pcie_copy_mem_todev with memcpy_toio · Andy Shevchenko <hidden> · 2022-01-20
[PATCH v3 7/9] brcmfmac: of: Use devm_kstrdup for board_type & check for errors · Hector Martin <hidden> · 2022-01-17
Re: [PATCH v3 7/9] brcmfmac: of: Use devm_kstrdup for board_type & check for errors · Arend van Spriel <arend.vanspriel@broadcom.com> · 2022-01-19
Re: [PATCH v3 7/9] brcmfmac: of: Use devm_kstrdup for board_type & check for errors · Andy Shevchenko <hidden> · 2022-01-20
[PATCH v3 4/9] brcmfmac: pcie: Declare missing firmware files in pcie.c · Hector Martin <hidden> · 2022-01-17
[PATCH v3 8/9] brcmfmac: fwil: Constify iovar name arguments · Hector Martin <hidden> · 2022-01-17
Re: [PATCH v3 8/9] brcmfmac: fwil: Constify iovar name arguments · Arend van Spriel <arend.vanspriel@broadcom.com> · 2022-01-19
Re: [PATCH v3 8/9] brcmfmac: fwil: Constify iovar name arguments · Andy Shevchenko <hidden> · 2022-01-20
[PATCH v3 6/9] brcmfmac: pcie: Fix crashes due to early IRQs · Hector Martin <hidden> · 2022-01-17
[PATCH v3 9/9] brcmfmac: pcie: Read the console on init and shutdown · Hector Martin <hidden> · 2022-01-17
Re: [PATCH v3 9/9] brcmfmac: pcie: Read the console on init and shutdown · Arend van Spriel <arend.vanspriel@broadcom.com> · 2022-01-19
Re: [PATCH v3 0/9] misc brcmfmac fixes (M1/T2 series spin-off) · Andy Shevchenko <hidden> · 2022-01-18
Re: [PATCH v3 0/9] misc brcmfmac fixes (M1/T2 series spin-off) · Hector Martin <hidden> · 2022-01-18
Re: [PATCH v3 0/9] misc brcmfmac fixes (M1/T2 series spin-off) · Andy Shevchenko <hidden> · 2022-01-18

From: Arend van Spriel <arend.vanspriel@broadcom.com>
Date: 2022-01-19 12:35:33
Also in: linux-acpi, linux-devicetree, linux-wireless, lkml

On 1/17/2022 3:29 PM, Hector Martin wrote:

This unbreaks support for USB devices, which do not have a board_type
to create an alt_path out of and thus were running into a NULL
dereference.

Fixes: 5ff013914c62 ("brcmfmac: firmware: Allow per-board firmware binaries")

Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>

Signed-off-by: Hector Martin <redacted>
---
  drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c | 3 +++
  1 file changed, 3 insertions(+)

Attachments

smime.p7s [application/pkcs7-signature] 4219 bytes

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help