RE: [Intel-wired-lan] [PATCH v4 net-next 5/9] ice: respect metadata on XSK Rx to skb
From: Bhandare, KiranX <hidden>
Date: 2022-01-10 11:38:25
Also in:
bpf, intel-wired-lan, lkml
-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf Of
Alexander Lobakin
Sent: Wednesday, December 8, 2021 7:37 PM
To: intel-wired-lan@lists.osuosl.org
Cc: Song Liu <redacted>; Alexei Starovoitov <ast@kernel.org>;
Andrii Nakryiko [off-list ref]; Daniel Borkmann
[off-list ref]; John Fastabend [off-list ref];
Jesper Dangaard Brouer [off-list ref]; Yonghong Song
[off-list ref]; Jesper Dangaard Brouer [off-list ref]; KP Singh
[off-list ref]; Jakub Kicinski [off-list ref];
netdev@vger.kernel.org; linux-kernel@vger.kernel.org; David S. Miller
[off-list ref]; Björn Töpel [off-list ref];
bpf@vger.kernel.org; Martin KaFai Lau [off-list ref]
Subject: [Intel-wired-lan] [PATCH v4 net-next 5/9] ice: respect metadata on
XSK Rx to skb
For now, if the XDP prog returns XDP_PASS on XSK, the metadata will be lost
as it doesn't get copied to the skb.
Copy it along with the frame headers. Account its size on skb allocation, and
when copying just treat it as a part of the frame and do a pull after to "move"
it to the "reserved" zone.
net_prefetch() xdp->data_meta and align the copy size to speed-up
memcpy() a little and better match ice_costruct_skb().
Fixes: 2d4238f55697 ("ice: Add support for AF_XDP")
Suggested-by: Jesper Dangaard Brouer <redacted>
Suggested-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Signed-off-by: Alexander Lobakin <redacted>
Reviewed-by: Michal Swiatkowski <redacted>
---
drivers/net/ethernet/intel/ice/ice_xsk.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)Tested-by: Kiran Bhandare <redacted> A Contingent Worker at Intel