RE: [EXT] [PATCH] scsi: qedf: potential dereference of null pointer

-----Original Message-----
From: Jiasheng Jiang <redacted>
Sent: Thursday, December 16, 2021 3:45 PM
To: Saurav Kashyap <skashyap@marvell.com>; Javed Hasan
[off-list ref]; GR-QLogic-Storage-Upstream <GR-QLogic-Storage-
Upstream@marvell.com>; jejb@linux.ibm.com; martin.petersen@oracle.com;
linux@armlinux.org.uk
Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org;
netdev@vger.kernel.org; Jiasheng Jiang [off-list ref]
Subject: [EXT] [PATCH] scsi: qedf: potential dereference of null pointer

External Email

----------------------------------------------------------------------
The return value of dma_alloc_coherent() needs to be checked.
To avoid use of null pointer in case of the failure of alloc.

Fixes: 61d8658b4a43 ("scsi: qedf: Add QLogic FastLinQ offload FCoE driver
framework.")
Signed-off-by: Jiasheng Jiang <redacted>
---
 drivers/scsi/qedf/qedf_main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index b92570a7c309..309e205a8e70 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c

@@ -1415,6 +1415,8 @@ static void qedf_upload_connection(struct qedf_ctx

*qedf,
 	 */
 	term_params = dma_alloc_coherent(&qedf->pdev->dev,
QEDF_TERM_BUFF_SIZE,
 		&term_params_dma, GFP_KERNEL);
+	if (!term_params)
+		return;