Re: [PATCH net-next 4/5] net: lan743x: Add support of selection between SGMII and GMII Interface
From: Andrew Lunn <andrew@lunn.ch>
Date: 2022-01-31 21:38:21
From: Andrew Lunn <andrew@lunn.ch>
Date: 2022-01-31 21:38:21
Accepted. I will change.quoted
quoted
+ if (chip_ver & STRAP_READ_SGMII_EN_) { + sgmii_ctl = lan743x_csr_read(adapter, SGMII_CTL); + sgmii_ctl |= SGMII_CTL_SGMII_ENABLE_; + sgmii_ctl &= ~SGMII_CTL_SGMII_POWER_DN_; + lan743x_csr_write(adapter, SGMII_CTL, sgmii_ctl); + netif_info(adapter, drv, adapter->netdev, "SGMII operation\n");And def initially this and the next one.I did not get "def initially" means ?
I suspect that was my spelling checker getting confused, or me picking the wrong suggestion. I meant 'definitely'. You don't want to spam the log with SGMII vs GMII operation in the normal case. This should be netif_dbg() Andrew