On Sat, 29 Jan 2022 12:24:47 +0100 (CET) Justin Iurman wrote:

quoted

quoted

+	IOAM6_IPTUNNEL_FREQ_K,		/* s32 */
+	IOAM6_IPTUNNEL_FREQ_N,		/* s32 */  

You can't insert into the middle of a uAPI enum. Binary compatibility.  

Is it really the middle? I recall adding the "mode" at the top (still
below the "_UNSPEC"), which I thought was correct at that time (and had
no objection).

Maybe because both changes were made in the same kernel release?
Not sure.

That's why I did the same here. Should I move it to the end, then?

You have to move it. I don't see how this patch as is wouldn't change
the value of IOAM6_IPTUNNEL_MODE.