On 2022-01-21 11:27, Shuah Khan wrote:

On 1/21/22 7:11 AM, Jamal Hadi Salim wrote:

quoted

On 2022-01-21 04:36, Davide Caratti wrote:

quoted

On Thu, Jan 20, 2022 at 8:34 PM Jamal Hadi Salim [off-list ref] 
wrote:

[..]

Several tests check for config support for their dependencies in their
test code - I don't see any of those in tc-testing. Individual tests
are supposed to check for not just the config dependencies, but also
any feature dependency e.g syscall/ioctl.

Couple of way to fix this problem for tc-testing - enhance the test to
check for dependencies and skip with a clear message on why test is
skipped.

A second option is enhancing the tools/testing/selftests/kselftest_deps.sh
script that checks for build depedencies. This tool can be enhanced easily
to check for run-time dependencies and use this in your automation.

Usage: ./kselftest_deps.sh -[p] <compiler> [test_name]

     kselftest_deps.sh [-p] gcc
     kselftest_deps.sh [-p] gcc vm
     kselftest_deps.sh [-p] aarch64-linux-gnu-gcc
     kselftest_deps.sh [-p] aarch64-linux-gnu-gcc vm

- Should be run in selftests directory in the kernel repo.
- Checks if Kselftests can be built/cross-built on a system.
- Parses all test/sub-test Makefile to find library dependencies.
- Runs compile test on a trivial C file with LDLIBS specified
   in the test Makefiles to identify missing library dependencies.
- Prints suggested target list for a system filtering out tests
   failed the build dependency check from the TARGETS in Selftests
   main Makefile when optional -p is specified.
- Prints pass/fail dependency check for each tests/sub-test.
- Prints pass/fail targets and libraries.
- Default: runs dependency checks on all tests.
- Optional test name can be specified to check dependencies for it.

Thanks Shuah. We'll look at this approach.
Question: How do we get reports when the bot finds a regression?


cheers,
jamal