Re: [PATCH net-next 01/15] mii: remove mii_lpa_to_linkmode_lpa_sgmii()
From: Vladimir Oltean <olteanv@gmail.com>
Date: 2022-01-27 12:36:35
On Wed, Jan 26, 2022 at 11:10:55AM -0800, Jakub Kicinski wrote:
quoted hunk ↗ jump to hunk
The only caller of mii_lpa_to_linkmode_lpa_sgmii() disappeared in v5.10. Signed-off-by: Jakub Kicinski <kuba@kernel.org> -- CC: Vladimir Oltean <olteanv@gmail.com> CC: Andrew Lunn <andrew@lunn.ch> CC: Heiner Kallweit <hkallweit1@gmail.com> CC: Russell King <linux@armlinux.org.uk> --- include/linux/mii.h | 17 ----------------- 1 file changed, 17 deletions(-)diff --git a/include/linux/mii.h b/include/linux/mii.h index 12ea29e04293..b8a1a17a87dd 100644 --- a/include/linux/mii.h +++ b/include/linux/mii.h@@ -387,23 +387,6 @@ mii_lpa_mod_linkmode_lpa_sgmii(unsigned long *lp_advertising, u32 lpa) speed_duplex == LPA_SGMII_10FULL); } -/** - * mii_lpa_to_linkmode_adv_sgmii - * @advertising: pointer to destination link mode. - * @lpa: value of the MII_LPA register - * - * A small helper function that translates MII_ADVERTISE bits - * to linkmode advertisement settings when in SGMII mode. - * Clears the old value of advertising. - */ -static inline void mii_lpa_to_linkmode_lpa_sgmii(unsigned long *lp_advertising, - u32 lpa) -{ - linkmode_zero(lp_advertising); - - mii_lpa_mod_linkmode_lpa_sgmii(lp_advertising, lpa); -} -
This is also the only caller of mii_lpa_mod_linkmode_lpa_sgmii(), so that function can be deleted too.
/** * mii_adv_mod_linkmode_adv_t * @advertising:pointer to destination link mode. -- 2.34.1