Re: [PATCH net-next v4 03/13] net: wwan: t7xx: Add core components

On Tue, 25 Jan 2022, Martinez, Ricardo wrote:

On 1/24/2022 6:51 AM, Ilpo Järvinen wrote:

quoted

On Thu, 13 Jan 2022, Ricardo Martinez wrote:

quoted

From: Haijun Liu <haijun.liu@mediatek.com>

Registers the t7xx device driver with the kernel. Setup all the core
components: PCIe layer, Modem Host Cross Core Interface (MHCCIF),
modem control operations, modem state machine, and build
infrastructure.

* PCIe layer code implements driver probe and removal.
* MHCCIF provides interrupt channels to communicate events
   such as handshake, PM and port enumeration.
* Modem control implements the entry point for modem init,
   reset and exit.
* The modem status monitor is a state machine used by modem control
   to complete initialization and stop. It is used also to propagate
   exception events reported by other components.

Signed-off-by: Haijun Liu <haijun.liu@mediatek.com>
Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>
Co-developed-by: Ricardo Martinez <ricardo.martinez@linux.intel.com>
Signed-off-by: Ricardo Martinez <ricardo.martinez@linux.intel.com>
---

Some states in t7xx_common.h (MD_STATE_...) would logically belong to this
patch instead of 02/. ...I think they were initally here but got moved
with t7xx_skb_data_area_size(). And there was also things clearly related
to 05/ in t7xx_common.h (at least CTL_ID_*).

Originally, 02 and 03 were going to be part of the same "Core functionality"
patch,

the only reason for splitting it was to make that core patch smaller. The
result is that

02 uses code defined at 03, note that compilation is enabled at 03.

Will merge 02 and 03 in the next version, also clean t7xx_common.h from
definitions

not used.

I didn't mind the core split itself but some things just logically seemed 
to clearly belong to the other side of the split (or to a later patch 
altogether). As the split was made mostly based on files rather than on 
logical level, it is no surprise some defs end up into wrong side of it.
That being said, then there's IMHO no need to go entirely overboard with 
this and fine-comb every single line in the header files.

And yes, I know the compile cannot fail until 03. However, the other 
aspect is that when somebody, a few years from now, has to look to 
these changes from the git history, having most of the elements in
logical places will help.


-- 
 i.