Thread (13 messages) 13 messages, 3 authors, 2022-01-26

Re: [PATCH V2 0/4] vDPA/ifcvf: implement shared IRQ feature

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2022-01-25 19:32:53
Also in: virtualization

On Tue, Jan 25, 2022 at 05:17:40PM +0800, Zhu Lingshan wrote:
It has been observed that on some platforms/devices, there may
not be enough MSI vectors for virtqueues and the config change.
Under such circumstances, the interrupt sources of a device
have to share vectors/IRQs.

This series implemented a shared IRQ feature for ifcvf.
Which configurations did you test with this, and what were
the results? Given patch 3 is broken ...

Please help review.

Changes from V1:
(1) Enable config interrupt when only one vector is allocated(Michael)
(2) Clean vectors/IRQs if failed to request config interrupt
since config interrupt is a must(Michael)
(3) Keep local vdpa_ops, disable irq_bypass by setting IRQ = -EINVAL
for shared IRQ case(Michael)
(4) Improvements on error messages(Michael)
(5) Squash functions implementation patches to the callers(Michael)

Zhu Lingshan (4):
  vDPA/ifcvf: implement IO read/write helpers in the header file
  vDPA/ifcvf: implement device MSIX vector allocator
  vhost_vdpa: don't setup irq offloading when irq_num < 0
  vDPA/ifcvf: implement shared IRQ feature

 drivers/vdpa/ifcvf/ifcvf_base.c |  67 +++------
 drivers/vdpa/ifcvf/ifcvf_base.h |  60 +++++++-
 drivers/vdpa/ifcvf/ifcvf_main.c | 254 ++++++++++++++++++++++++++++----
 drivers/vhost/vdpa.c            |   3 +
 4 files changed, 305 insertions(+), 79 deletions(-)

-- 
2.27.0
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help