Re: [PATCH net-next 3/4] bnxt_en: use firmware provided max timeout for messages
flat view
From: Jakub Kicinski <kuba@kernel.org>
Date: 2022-01-09 21:58:49
On Sat, 8 Jan 2022 20:38:47 -0500 Michael Chan wrote:
quoted hunk ↗ jump to hunk
-#define FLASH_NVRAM_TIMEOUT ((HWRM_CMD_TIMEOUT) * 100) -#define FLASH_PACKAGE_TIMEOUT ((HWRM_CMD_TIMEOUT) * 200) -#define INSTALL_PACKAGE_TIMEOUT ((HWRM_CMD_TIMEOUT) * 200) +#define FLASH_NVRAM_TIMEOUT (bp->hwrm_cmd_max_timeout) +#define FLASH_PACKAGE_TIMEOUT (bp->hwrm_cmd_max_timeout) +#define INSTALL_PACKAGE_TIMEOUT (bp->hwrm_cmd_max_timeout)
-#define HWRM_COREDUMP_TIMEOUT ((HWRM_CMD_TIMEOUT) * 12) +#define HWRM_COREDUMP_TIMEOUT (bp->hwrm_cmd_max_timeout)
Please don't use variables which are not argument of the macro. Why not replace the uses?