Re: [PATCH net-next v5 4/8] net/funeth: ethtool operations
From: Jakub Kicinski <kuba@kernel.org>
Date: 2022-01-07 04:44:37
From: Jakub Kicinski <kuba@kernel.org>
Date: 2022-01-07 04:44:37
On Thu, 6 Jan 2022 20:36:08 -0800 Dimitris Michailidis wrote:
+ if (netif_running(netdev))
+ netdev->netdev_ops->ndo_stop(netdev);
+
+ old_tx = netdev->real_num_tx_queues;
+ old_rx = netdev->real_num_rx_queues;
+ set_ring_count(netdev, chan->tx_count, chan->rx_count);
+
+ if (netif_running(netdev)) {
+ rc = netdev->netdev_ops->ndo_open(netdev);
+ if (rc) {
+ set_ring_count(netdev, old_tx, old_rx);
+ netdev->netdev_ops->ndo_open(netdev);Sorry, I wasn't clear - same story as with XDP - configuration changes should not run at risk of having the machine drop off the network due to temporary memory pressure.