[PATCH v2 net-next 2/6] net: dsa: merge rtnl_lock sections in dsa_slave_create
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: 2022-01-05 23:11:39
Subsystem:
networking [dsa], networking [general], the rest · Maintainers:
Andrew Lunn, Vladimir Oltean, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Currently dsa_slave_create() has two sequences of rtnl_lock/rtnl_unlock in a row. Remove the rtnl_unlock() and rtnl_lock() in between, such that the operation can execute slighly faster. Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> --- net/dsa/slave.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index 88bcdba92fa7..22241afcac81 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c@@ -2022,14 +2022,12 @@ int dsa_slave_create(struct dsa_port *port) } rtnl_lock(); + ret = dsa_slave_change_mtu(slave_dev, ETH_DATA_LEN); - rtnl_unlock(); if (ret && ret != -EOPNOTSUPP) dev_warn(ds->dev, "nonfatal error %d setting MTU to %d on port %d\n", ret, ETH_DATA_LEN, port->index); - rtnl_lock(); - ret = register_netdevice(slave_dev); if (ret) { netdev_err(master, "error %d registering interface %s\n",
--
2.25.1