Thread (14 messages) 14 messages, 3 authors, 2021-12-17

RE: [Intel-wired-lan] [PATCH v2 intel-net 4/6] ice: xsk: do not clear status_error0 for ntu + nb_buffs descriptor

From: Bhandare, KiranX <hidden>
Date: 2021-12-17 15:24:04
Also in: bpf, intel-wired-lan

-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf Of
Maciej Fijalkowski
Sent: Monday, December 13, 2021 9:01 PM
To: intel-wired-lan@lists.osuosl.org
Cc: Mathew, Elza <redacted>; netdev@vger.kernel.org;
kuba@kernel.org; bpf@vger.kernel.org; davem@davemloft.net; Karlsson,
Magnus [off-list ref]
Subject: [Intel-wired-lan] [PATCH v2 intel-net 4/6] ice: xsk: do not clear
status_error0 for ntu + nb_buffs descriptor

The descriptor that ntu is pointing at when we exit
ice_alloc_rx_bufs_zc() should not have its corresponding DD bit cleared as
descriptor is not allocated in there and it is not valid for HW usage.

The allocation routine at the entry will fill the descriptor that ntu points to
after it was set to ntu + nb_buffs on previous call.

Even the spec says:
"The tail pointer should be set to one descriptor beyond the last empty
descriptor in host descriptor ring."

Therefore, step away from clearing the status_error0 on ntu + nb_buffs
descriptor.

Fixes: db804cfc21e9 ("ice: Use the xsk batched rx allocation interface")
Reported-by: Elza Mathew <redacted>
Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_xsk.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
Tested-by: Kiran Bhandare <redacted>  A Contingent Worker at Intel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help