Re: [PATCH bpf-next 3/5] selftests/bpf: factor out common helpers for benchmarks

Hi,

On 12/7/2021 10:55 AM, Andrii Nakryiko wrote:

On Tue, Nov 30, 2021 at 6:07 AM Hou Tao [off-list ref] wrote:

quoted

Five helpers are factored out to reduce boilerplate for
benchmark tests: do_getpgid(), getpgid_loop_producer(),
assert_single_consumer(), assert_single_producer() and
noop_consumer().

Signed-off-by: Hou Tao <redacted>
---

Please drop this patch. All the stuff you are extracting into
"reusable" helpers is so trivial that it's not worth it. It just makes
it harder to follow each individual benchmark's setup.

OK. Will do it v2.